Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRAPPER: Update patch location, use --patch syntax #309

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

effigies
Copy link
Member

@effigies effigies commented Nov 9, 2022

Needed to debug #303

Comment on lines +235 to +240
def _is_file(path, parser):
"""Ensure a given path exists and it is a file."""
path = os.path.abspath(path)
if not os.path.isfile(path):
raise parser.error("Path should point to a file (or symlink of file): <%s>." % path)
return path
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not currently used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use it. I assume it solved a problem in fmriprep-docker, so might as well have it here...

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Base: 67.20% // Head: 67.20% // No change to project coverage 👍

Coverage data is based on head (a839c97) compared to base (d35824d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #309   +/-   ##
=======================================
  Coverage   67.20%   67.20%           
=======================================
  Files          17       17           
  Lines        1168     1168           
  Branches      200      200           
=======================================
  Hits          785      785           
  Misses        327      327           
  Partials       56       56           
Flag Coverage Δ
ds005 57.44% <ø> (ø)
ds054 49.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies effigies requested a review from mgxd November 9, 2022 19:28
@effigies effigies merged commit 05a762b into nipreps:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants