Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Merge T2w images and coregister to T1w template #319

Merged
merged 3 commits into from
Jan 26, 2023

Conversation

effigies
Copy link
Member

The approach taken here is to merge the T2w images in exactly the same way as T1w images (N4 -> mri_robust_template) and then bbregister. This is the approach taken by recon-all, and seems the safest way to do this without running brain extraction first. Therefore this is only available if FreeSurfer is run.

Closes #69.

We could probably throw in #13 at the same time and pass the merged T2w image to FreeSurfer...

@effigies effigies force-pushed the enh/t2w-alignment branch 2 times, most recently from d9a6306 to 3b63103 Compare January 21, 2023 04:11
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2023

Codecov Report

Base: 70.29% // Head: 66.58% // Decreases project coverage by -3.71% ⚠️

Coverage data is based on head (b41116b) compared to base (270762f).
Patch coverage: 20.83% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
- Coverage   70.29%   66.58%   -3.71%     
==========================================
  Files          17       18       +1     
  Lines        1168     1185      +17     
  Branches      200      202       +2     
==========================================
- Hits          821      789      -32     
- Misses        284      338      +54     
+ Partials       63       58       -5     
Flag Coverage Δ
ds005 56.96% <20.83%> (-3.83%) ⬇️
ds054 48.86% <20.83%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
smriprep/workflows/base.py 80.00% <ø> (ø)
smriprep/workflows/outputs.py 63.75% <0.00%> (-2.06%) ⬇️
smriprep/workflows/anatomical.py 51.23% <26.31%> (-2.37%) ⬇️
smriprep/interfaces/surf.py 32.00% <0.00%> (-38.00%) ⬇️
smriprep/interfaces/freesurfer.py 56.43% <0.00%> (-10.90%) ⬇️
smriprep/interfaces/reports.py 86.07% <0.00%> (-6.33%) ⬇️
smriprep/cli/run.py 76.99% <0.00%> (-0.47%) ⬇️
smriprep/__init__.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies
Copy link
Member Author

Raw

image

Preprocessed

image

@effigies effigies requested a review from mgxd January 25, 2023 22:23
Copy link
Collaborator

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, now that we are double dipping with some workflows, it may be time to change the parameters/inputs/outputs to reflect this generalization

smriprep/workflows/anatomical.py Outdated Show resolved Hide resolved
smriprep/workflows/anatomical.py Outdated Show resolved Hide resolved
smriprep/workflows/anatomical.py Outdated Show resolved Hide resolved
@effigies
Copy link
Member Author

Tests verifying that this doesn't break for no T2w images, and I've rerun locally with T2 and gotten the same result. Merging.

@effigies effigies merged commit 99b0cfd into nipreps:master Jan 26, 2023
@effigies effigies deleted the enh/t2w-alignment branch January 26, 2023 17:05
mgxd added a commit to nipreps/fmriprep that referenced this pull request Jan 27, 2023
## Changes proposed in this pull request

Integrates and connects up nipreps/smriprep#319.

## Documentation that should be reviewed

* [x] Mention in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Register the FLAIR or T2 to the T1w space
3 participants