ENH: Enable resampling morphometrics to fsLR CIFTI-2 files #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
force-pushed
the
enh/morphometric_dscalar
branch
4 times, most recently
from
73fa73b
to
a22ee57
Compare
effigies
force-pushed
the
enh/morphometric_dscalar
branch
from
1006009
to
81d5fac
Compare
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #325 +/- ##
===========================================
+ Coverage 26.68% 66.07% +39.38%
===========================================
Files 18 20 +2
Lines 1229 1353 +124
Branches 179 227 +48
===========================================
+ Hits 328 894 +566
+ Misses 888 398 -490
- Partials 13 61 +48
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
effigies
force-pushed
the
enh/morphometric_dscalar
branch
from
2dafe6e
to
3317fd7
Compare
|
@mgxd I would appreciate a review here. I'll fix the flake8 failure (unused import) just before merging. No need to cycle the CI for it. |
mgxd
reviewed
Mar 1, 2023
There was a problem hiding this comment.
Nice!
Very minor comments, otherwise looks good to me. It would be good to have @madisoth (or someone else working with CIFTI outputs) verify these outputs are similar to those generated from the wb_commands, to ensure we can be as 1:1 as possible.
Co-authored-by: Mathias Goncalves <goncalves.mathias@gmail.com>
effigies
force-pushed
the
enh/morphometric_dscalar
branch
from
580210e
to
c2628cf
Compare
Also remove false dependency from workflow step causing autorecon3 to always retry -apas2aseg
effigies
force-pushed
the
enh/morphometric_dscalar
branch
from
5753419
to
9fc8688
Compare
|
@madisoth: You're probably running into this bug: The latest commit fixes that. |
|
Just a note that I've now run through a downsampled test dataset successfully including this and the three open PRs on fMRIPrep. Rerunning now with full res ds005/sub-01 from scratch. |
… not add hemisphere prefix
effigies
force-pushed
the
enh/morphometric_dscalar
branch
from
2f4a181
to
f3af1de
Compare
effigies
added a commit
to nipreps/fmriprep
that referenced
this pull request
Mar 6, 2023
…-output` is used (#2959) Depends on nipreps/smriprep#325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently inaccessible to smriprep itself because I don't want to add and test a CLI option. Could probably go into a bug-fix release if someone cares about it before the next minor release.