Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RF: Reflect function name on nipype workflow #328

Merged
merged 1 commit into from Mar 17, 2023
Merged

RF: Reflect function name on nipype workflow #328

merged 1 commit into from Mar 17, 2023

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Mar 17, 2023

Minor (but breaking) change - I spent way too long looking for morph_grayords_wf in the working directory...

@mgxd mgxd requested a review from effigies March 17, 2023 14:06
effigies
effigies approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically breaking, but I'm inclined to consider it a bug-fix, as it will at worst duplicate a small workflow on re-run, but not invalidate the output of a node that will not get rerun.

I'm sorry about this one...

@mgxd
Copy link
Collaborator Author

mgxd commented Mar 17, 2023

I'm okay with targeting 0.11.1 if you are 😄

@effigies effigies merged commit 00a23f9 into nipreps:master Mar 17, 2023
@mgxd mgxd deleted the rf/grayords-wf-name branch March 17, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mgxd @effigies