Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Add sloppy argument to workflows, distinguish from debug #344

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Jun 2, 2023

This adds sloppy to the anatomical workflow (and all necessary children), and distinguishes between debug, which produces intermediate outputs to facilitate debug certain preprocessing steps (currently none), and sloppy, which sacrifices algorithmic performance for speed.

ATM, debug has no options, but I left it open to future additions.

Needed for nipreps/nibabies#290

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shall we get this in for 0.12.0?

@mgxd
Copy link
Collaborator Author

mgxd commented Jun 2, 2023

YES

@effigies effigies added this to the 0.12.0 milestone Jun 2, 2023
@effigies
Copy link
Member

effigies commented Jun 2, 2023

Do we need a corresponding fMRIPrep patch?

@mgxd mgxd marked this pull request as ready for review June 2, 2023 18:18
@mgxd
Copy link
Collaborator Author

mgxd commented Jun 2, 2023

Yes, I can open it

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (0cd77e3) 54.14% compared to head (60f0266) 54.14%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #344   +/-   ##
=======================================
  Coverage   54.14%   54.14%           
=======================================
  Files          22       22           
  Lines        1461     1461           
  Branches      242      242           
=======================================
  Hits          791      791           
  Misses        614      614           
  Partials       56       56           
Flag Coverage Δ
ds005 ∅ <ø> (∅)
ds054 44.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
smriprep/cli/run.py 74.17% <ø> (ø)
smriprep/workflows/anatomical.py 45.56% <ø> (ø)
smriprep/workflows/base.py 71.66% <ø> (ø)
smriprep/workflows/norm.py 97.50% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies effigies merged commit c2158aa into nipreps:master Jun 2, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants