Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Pass sphere_reg_fsLR to ds_reg_fsLR #350

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

effigies
Copy link
Member

Woops. Thanks to @Shotgunosine for noticing that the outputs looked suspiciously similar.

@effigies effigies added the bug Something isn't working label Jun 15, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (0f78fa2) 54.14% compared to head (0ef7074) 54.14%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@              Coverage Diff              @@
##           maint/0.12.x     #350   +/-   ##
=============================================
  Coverage         54.14%   54.14%           
=============================================
  Files                22       22           
  Lines              1461     1461           
  Branches            242      242           
=============================================
  Hits                791      791           
  Misses              614      614           
  Partials             56       56           
Flag Coverage Δ
ds005 ∅ <ø> (∅)
ds054 44.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
smriprep/workflows/outputs.py 46.51% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

smriprep/workflows/outputs.py Outdated Show resolved Hide resolved
@effigies effigies merged commit ecf5b0b into nipreps:maint/0.12.x Jun 15, 2023
12 checks passed
@effigies effigies deleted the fix/fslr-reg-connection branch June 15, 2023 17:28
effigies added a commit that referenced this pull request Jun 19, 2023
0.12.1 (June 15, 2023)

Bug-fix release in the 0.12.x series.

This release correctly generates ``*_space-fsLR_desc-reg_sphere.surf.gii``,
which was previously a copy of the standard ``*_desc-reg_sphere.surf.gii``.

* FIX: Pass sphere_reg_fsLR to ds_reg_fsLR (#350)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants