ENH: Separate surfaces and morphometrics into standalone outputs #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
approved these changes
Aug 22, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #359 +/- ##
==========================================
- Coverage 54.07% 54.03% -0.05%
==========================================
Files 22 22
Lines 1459 1488 +29
Branches 206 209 +3
==========================================
+ Hits 789 804 +15
- Misses 614 628 +14
Partials 56 56
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Nope, though looks like it at least ran & completed in the circle tests. I'm using it for #358 so will test be tested there |
|
Tested locally 👍 |
effigies
reviewed
Aug 23, 2023
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
|
I'm okay with merging this, but you left it in draft state. Good to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than handling the paring down of surfaces when needed, this PR adds an aggregator node to collect and sort each surface output into a L/R list, simplifying retrieval for future use.