Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Update installation environment #361

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

effigies
Copy link
Member

@effigies effigies commented Aug 27, 2023

Bringing things up-to-date with fMRIPrep.

Closes #354.

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5e60fd8) 54.03% compared to head (1056b37) 54.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #361   +/-   ##
=======================================
  Coverage   54.03%   54.03%           
=======================================
  Files          22       22           
  Lines        1488     1488           
  Branches      209      209           
=======================================
  Hits          804      804           
  Misses        628      628           
  Partials       56       56           
Flag Coverage Δ
ds005 ∅ <ø> (∅)
ds054 44.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines -26 to -27
- convert3d=1.3.0
- libitk=5.2 # 5.3 fails with c3d
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note sMRIPrep doesn't actually use convert3d, only fMRIPrep does.

@effigies
Copy link
Member Author

effigies commented Aug 28, 2023

Ready for review. Note this is targeting master.

@effigies effigies merged commit a45a8ea into nipreps:master Aug 31, 2023
18 checks passed
@effigies effigies deleted the mnt/env branch August 31, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant