Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Add sloppy MSM configuration for use in debugging/CI #366

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

effigies
Copy link
Member

@effigies effigies commented Sep 6, 2023

MSM is taking ~30min to run on fMRIPrep CI. This adds a sloppy configuration that will hopefully reduce that dramatically.

@effigies effigies changed the title TEST: Add sloppy TEST: Add sloppy MSM configuration for use in debugging/CI Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: -11.12% ⚠️

Comparison is base (37ad1c6) 54.65% compared to head (4e6fdd3) 43.54%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #366       +/-   ##
===========================================
- Coverage   54.65%   43.54%   -11.12%     
===========================================
  Files          23       23               
  Lines        1588     1589        +1     
  Branches      212      208        -4     
===========================================
- Hits          868      692      -176     
- Misses        664      842      +178     
+ Partials       56       55        -1     
Flag Coverage Δ
ds005 ?
ds054 43.54% <40.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
smriprep/workflows/anatomical.py 45.56% <0.00%> (ø)
smriprep/workflows/surfaces.py 11.51% <50.00%> (-0.07%) ⬇️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Member Author

effigies commented Sep 6, 2023

230906-17:55:17,627 nipype.workflow INFO:
         [Node] Finished "_msmsulc1", elapsed time 164.174763s.
230906-17:55:49,585 nipype.workflow INFO:
         [Node] Finished "_msmsulc0", elapsed time 196.20051s.

Copy link
Collaborator

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet!

@mgxd mgxd merged commit b8a1949 into nipreps:master Sep 6, 2023
16 of 18 checks passed
@effigies effigies deleted the test/msm-sloppy branch September 6, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants