FIX: Invert sulcal depth metric before passing to MSM, use HCP atlas files #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
force-pushed
the
fix/msm-invert-sulc
branch
from
98d27ee
to
eeead71
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #383 +/- ##
==========================================
- Coverage 58.65% 58.35% -0.31%
==========================================
Files 26 27 +1
Lines 1872 1904 +32
Branches 238 239 +1
==========================================
+ Hits 1098 1111 +13
- Misses 717 736 +19
Partials 57 57
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
effigies
force-pushed
the
fix/msm-invert-sulc
branch
from
eeead71
to
2dfd246
Compare
effigies
force-pushed
the
fix/msm-invert-sulc
branch
from
2dfd246
to
c6246bc
Compare
effigies
changed the title
mgxd
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
I think this is right, but let's wait on CI to catch any smoke. One thing we should probably discuss (probably at the next nipreps meeting) is the updating of templateflow templates, and the migration of these templates into it.
And thanks again to @madisoth for tracking this down!
effigies
added a commit
that referenced
this pull request
Nov 10, 2023
Invert sulcal depth and use correct atlases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR narrowly inverts sulcal depth metrics before passing to MSM. I do not currently invert sulcal depth and curvature for GIFTI/CIFTI morphometric outputs.