Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Split template and fsLR resampling and sinking into isolated workflows #388

Merged
merged 14 commits into from
Nov 19, 2023

Conversation

effigies
Copy link
Member

This is necessary to allow fMRIPrep to pick and choose workflows based on user requests.

This also replaces the old morphometry CIFTI-2 files with ones resampled along the lines of HCP.

@effigies effigies added the next label Nov 19, 2023
Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (6ce2121) 58.48% compared to head (0bf46d1) 57.52%.

Files Patch % Lines
smriprep/workflows/surfaces.py 30.76% 36 Missing ⚠️
smriprep/interfaces/gifti.py 40.90% 13 Missing ⚠️
smriprep/workflows/anatomical.py 18.18% 8 Missing and 1 partial ⚠️
smriprep/workflows/outputs.py 75.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #388      +/-   ##
==========================================
- Coverage   58.48%   57.52%   -0.97%     
==========================================
  Files          27       27              
  Lines        1910     1961      +51     
  Branches      240      239       -1     
==========================================
+ Hits         1117     1128      +11     
- Misses        736      778      +42     
+ Partials       57       55       -2     
Flag Coverage Δ
ds005 ∅ <ø> (∅)
ds054 46.07% <43.58%> (+0.08%) ⬆️
pytest 36.76% <24.78%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies force-pushed the rf/template-resampling-workflows branch 2 times, most recently from 9fd8116 to ddacc9e Compare November 19, 2023 17:44
@effigies effigies force-pushed the rf/template-resampling-workflows branch from ddacc9e to a08d9cf Compare November 19, 2023 17:49
@effigies effigies force-pushed the rf/template-resampling-workflows branch from f7c4a35 to afa5620 Compare November 19, 2023 18:45
@effigies effigies merged commit 3c2edb7 into nipreps:next Nov 19, 2023
14 of 16 checks passed
@effigies effigies deleted the rf/template-resampling-workflows branch November 19, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant