Split Enum value type from EnumTypeWrapper #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this approach takes the opinionated approach of returning a NewType over the int If you try to construct a message passing an int to the constructor, it will fail, expecting to be wrapped in the NewType |
|
FYI this is breaking our type checks, and it's not as simple as replacing MyEnum by MyEnumValue because MyEnumValue exists only during type checking. I'm converting all those types to string |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the conflation of the value type from the EnumTypeWrapper in the typing.
Added tests to confirm that we correctly error if used incorrectly.
Fixes #118