-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark mangled globals as TypeAlias
#607
Conversation
mine works. What's the trouble you're seeing? |
4b7d1cc
to
7b17521
Compare
Just some initial setup stuff I had to work through. Like having my files in CRLF (because I cloned from Windows with autocrlf on... oops) messing up the script, then figuring out how to install and use pyenv. But I think I got it working now. |
5460524
to
dad9126
Compare
dad9126
to
0a10dbd
Compare
Ah, if it ends end raising Y042 instead, I don't know if that's much better. Maybe a little bit since they don't seem to exist at runtime
Wouldn't they be better prefixed |
And now unused type aliases are (rightfully) detected by Y047 ^^" |
81a77b6
to
b158860
Compare
b158860
to
6fcb296
Compare
Yep this all seems reasonable! Prefixing with I'll try to tie up a few more fixes/updates and then release. |
Closes #600
TypeAlias
. (Y026)global___
toGlobal___
to respect Y042 naming convention.Refs https://github.com/PyCQA/flake8-pyi/blob/main/ERRORCODES.md#list-of-warnings