Fix 1127 #1129
Merged
Fix 1127 #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 81.15% (diff: 53.33%)@@ master #1129 diff @@
==========================================
Files 215 215
Lines 24370 24375 +5
Methods 0 0
Messages 0 0
Branches 2448 2449 +1
==========================================
+ Hits 19780 19781 +1
- Misses 4084 4086 +2
- Partials 506 508 +2
|
1 similar comment
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #1127. It seems that scipy optimize returns nans instead of -1 on Windows, for non-converging inputs. This converts these nan results into the expected all
-1.See try_branch here: http://nipy.bic.berkeley.edu/builders/dipy-bdist64-35-win2016/builds/42/steps/shell_11/logs/stdio
Fixed plenty of PEP8 violations while I was at it.