Fix for "Sliders in examples don't react properly to clicks" #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1457 +/- ##
==========================================
- Coverage 87.49% 87.48% -0.01%
==========================================
Files 241 241
Lines 30789 30805 +16
Branches 3322 3322
==========================================
+ Hits 26939 26951 +12
- Misses 3074 3078 +4
Partials 776 776
Continue to review full report at Codecov.
|
dipy/viz/ui.py
Outdated
| @@ -1851,7 +1851,7 @@ def handle_events(self, actor): | |||
|
|
|||
| """ | |||
| self.add_callback(self.slider_line, "LeftButtonPressEvent", | |||
| self.line_click_callback) | |||
| self.line_click_callback,1) | |||
There was a problem hiding this comment.
Add a space after the , in accordance with PEP8.
| line_slider = ui.LineSlider2D(initial_value=-2, | ||
| min_value=-5, max_value=5) | ||
|
|
||
| line_slider.add_callback(line_slider.slider_disk, | ||
| "MouseMoveEvent", | ||
| translate_green_cube) | ||
|
|
||
| line_slider.add_callback(line_slider.slider_line, |
There was a problem hiding this comment.
Can you do the same for the disk slider also? Let's merge both these into this PR.
|
Please also update viz_advanced.py. Once that is done, I think this is ready to merge. |
|
is it ready to go @dmreagan? |
dmreagan
approved these changes
Apr 5, 2018
ShreyasFadnavis
pushed a commit
to ShreyasFadnavis/dipy
that referenced
this pull request
Sep 20, 2018
Fix for "Sliders in examples don't react properly to clicks"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1454
translate_green_cubeon"LeftButtonPressEvent".self.line_click_callbackinui.pyto ensure that the position of disk gets updated before moving the cube.