Nf hemisphere preview #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just keep pushing to this branch--the PR updates automatically, and then we can merge when ready. |
| xyz=xyz, | ||
| faces=faces, edges=edges) | ||
|
|
||
| vertices = tmp.vertices |
There was a problem hiding this comment.
what do you not like about this? the name tmp?
There was a problem hiding this comment.
Sorry, I didn't see that tmp was defined right above...
|
Overall, this looks good to me. |
| pass | ||
| """Points on the unit sphere. | ||
|
|
||
| A HemiSphere is similar to a Sphere but it takes anitpodal symmetry into |
|
I'd love one more look over this, I think it's pretty much ready to merge. |
asagilmore
pushed a commit
to asagilmore/dipy
that referenced
this pull request
Apr 1, 2024
[WIP] Parallel test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not merge. I'll make another pull request with this, but I wanted to share this so you guys could take a look at the HemiSphere class and let me know what you think.