Fix diffeomorphic registration test failures #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1452,8 +1452,11 @@ def _iterate(self): | |||
| #set zero displacements at the boundary | |||
| fw_step[0, ...] = 0 | |||
| fw_step[:, 0, ...] = 0 | |||
| fw_step[-1, ...] = 0 | |||
There was a problem hiding this comment.
We need to set to zero all the boundaries. I missed the other side!
|
Hi @omarocegueda this is really great work that you did here with the SSE and the boundary interpolation. Great also to be able know compiler options both from cython and python. This is a game changer for Dipy. Please correct the minor pep8 issues and will go ahead and merge your PR. Thx brother!!! This is really cool! |
|
Thank you Elef!, |
Write the discovered compile-time variables into a file ``dipy/__config__.py`` so dipy code can act depending on the result of the compile - for example compile-time presence of openmp.
…t is generated before it is moved to the module install directory
omarocegueda
force-pushed
the
fix_profiles
branch
from
6c199e6
to
24dc623
Compare
|
Rebased =) |
|
Travis happy, let's hear the bots! Thx man! |
Garyfallidis
added a commit
that referenced
this pull request
Dec 8, 2014
Fix diffeomorphic registration test failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #464. This issue was caused by differences in floating-point operations when using double precision (64 bits), extended precision (80 bits) or a combination of both, whcih depends on the platform, compiler and compilation options used.
In summary, these are the proposals implemented in this PR: