Fix PEP8 in test_expectmax #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expected[random_labels == 1, 2] = delta_field[random_labels == 1]*grad_G[random_labels == 1, 2]/sqnrm | ||
|
|
||
| #Pixels with gradient=0 and sigma_i_sq=0 | ||
| expected[random_labels == 1, 0] = delta_field[ |
There was a problem hiding this comment.
Instead of breaking the line just after the square bracket [, I think something like:
expected[random_labels == 1, 0] = (delta_field[random_labels == 1] *
grad_G[random_labels == 1, 0] / sqnrm)
expected[random_labels == 1, 1] = (delta_field[random_labels == 1] *
grad_G[random_labels == 1, 1] / sqnrm)
expected[raendom_labels == 1, 2] = (delta_field[random_labels == 1] *
grad_G[random_labels == 1, 2] / sqnrm)
would be more readable and it still fits within the 79 character limit
|
Hi @ghoshbishakh!, =) |
|
thank you for reviewing. Ill try to fix the issues pointed and update PR |
|
@omarocegueda - I am +1 for a merge here, if this addressed all your comments. |
|
Oh! sorry I didn't notice it was done! merging now. |
omarocegueda
added a commit
that referenced
this pull request
Feb 14, 2016
|
Thank you @ghoshbishakh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #863