Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added eddy_rotated_bvecs extension #1411

Merged
merged 1 commit into from
Feb 6, 2018
Merged

Conversation

naveenkumarmarri
Copy link
Contributor

for issue #1117

@codecov-io
Copy link

codecov-io commented Feb 3, 2018

Codecov Report

Merging #1411 into master will decrease coverage by 0.56%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1411      +/-   ##
==========================================
- Coverage   87.26%   86.69%   -0.57%     
==========================================
  Files         229      236       +7     
  Lines       29588    29877     +289     
  Branches     3170     3206      +36     
==========================================
+ Hits        25821    25903      +82     
- Misses       3039     3238     +199     
- Partials      728      736       +8
Impacted Files Coverage Δ
dipy/io/gradients.py 76.47% <100%> (ø) ⬆️
dipy/reconst/benchmarks/bench_csd.py 18.42% <0%> (ø)
dipy/reconst/benchmarks/bench_peaks.py 30% <0%> (ø)
dipy/tracking/benchmarks/bench_streamline.py 19.44% <0%> (ø)
dipy/segment/benchmarks/bench_quickbundles.py 22.58% <0%> (ø)
dipy/reconst/benchmarks/bench_squash.py 43.07% <0%> (ø)
dipy/reconst/benchmarks/bench_vec_val_sum.py 50% <0%> (ø)
dipy/reconst/benchmarks/bench_bounding_box.py 31.25% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2de97d4...ca1ee73. Read the comment docs.

@skoudoro
Copy link
Member

skoudoro commented Feb 5, 2018

Thank you really much @naveenkumarmarri !

if no one has an objection, I will merge this one at the end of the day

@skoudoro
Copy link
Member

skoudoro commented Feb 5, 2018

Why you close it @naveenkumarmarri ? It is not merge yet....

@naveenkumarmarri
Copy link
Contributor Author

naveenkumarmarri commented Feb 5, 2018

Oops my bad, tried to update my branch and the PR got closed, I re opened this

@naveenkumarmarri
Copy link
Contributor Author

@skoudoro looks like this build didn't trigger at all.

@skoudoro
Copy link
Member

skoudoro commented Feb 6, 2018

Thanks for pointing that @naveenkumarmarri, I just restarted them

@skoudoro
Copy link
Member

skoudoro commented Feb 6, 2018

Thanks @naveenkumarmarri, merging!

@skoudoro skoudoro merged commit 7ae848e into dipy:master Feb 6, 2018
ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018
Added eddy_rotated_bvecs extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants