Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix potential zero division in demon regist. #1540

Merged
merged 1 commit into from
Jun 5, 2018
Merged

fix potential zero division in demon regist. #1540

merged 1 commit into from
Jun 5, 2018

Conversation

Borda
Copy link
Contributor

@Borda Borda commented May 30, 2018

No description provided.

@Borda
Copy link
Contributor Author

Borda commented May 30, 2018

it seems that the master is not passing tests...

@skoudoro
Copy link
Member

Hi @Borda, Thank you for this PR and we know this problem. We are trying to find a solution.

@Borda
Copy link
Contributor Author

Borda commented May 30, 2018

@skoudoro seems to be correlated with the recent release of cvxpy, see #1542

@Borda
Copy link
Contributor Author

Borda commented Jun 5, 2018

@skoudoro I this that this simple fix can be merged based on the passing tests, what do you think?

@skoudoro
Copy link
Member

skoudoro commented Jun 5, 2018

Yep, I think it can be merged, just waiting for Travis @Borda

@skoudoro
Copy link
Member

skoudoro commented Jun 5, 2018

Thanks @Borda for this fix!

@skoudoro skoudoro merged commit 4484514 into dipy:master Jun 5, 2018
ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018
fix potential zero division in demon regist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants