Changed the icon set in Button2D from Dictionary to List of Tuples #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmreagan
approved these changes
Jun 13, 2018
|
Thanks for fixing this @karandeepSJ :) |
karandeepSJ
added a commit
to karandeepSJ/dipy
that referenced
this pull request
Jun 16, 2018
|
@Garyfallidis @dmreagan @karandeepSJ This PR was modified (fixing a bug) after it got merged. Master is failing the tests at the moment. |
|
I did not push anything to this branch. Master is failing because of some error in the latest version of scipy. |
|
Yep. See #1565 |
|
Oh no - I am wrong. One of the failures does seem to be because of this branch: |
|
Now in #1573 |
Merged
|
Fixed |
karandeepSJ
added a commit
to karandeepSJ/dipy
that referenced
this pull request
Jul 3, 2018
karandeepSJ
added a commit
to karandeepSJ/dipy
that referenced
this pull request
Jul 24, 2018
karandeepSJ
added a commit
to karandeepSJ/dipy
that referenced
this pull request
Aug 1, 2018
ShreyasFadnavis
pushed a commit
to ShreyasFadnavis/dipy
that referenced
this pull request
Sep 20, 2018
Changed the icon set in Button2D from Dictionary to List of Tuples
ShreyasFadnavis
pushed a commit
to ShreyasFadnavis/dipy
that referenced
this pull request
Sep 20, 2018
Fixed Bug in PR dipy#1547
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Button2Dclass used a dictionary to store icons. The random ordering of dictionaries in Python was causing problems when a particular order was required for the button icons.This PR changes the dictionary to a list of tuples of the form
((icon_name, icon), (icon_name, icon), ....)