Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] remove Userwarning message #1630

Merged
merged 19 commits into from
Jul 24, 2019
Merged

Conversation

skoudoro
Copy link
Member

@skoudoro skoudoro commented Aug 27, 2018

During Travis build or example build, There is a bunch of warning.

This PR is the first of a series that track and resolve/remove them.

@codecov-io
Copy link

codecov-io commented Aug 27, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@51b6422). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1630   +/-   ##
=========================================
  Coverage          ?   85.41%           
=========================================
  Files             ?      119           
  Lines             ?    14299           
  Branches          ?     2243           
=========================================
  Hits              ?    12214           
  Misses            ?     1576           
  Partials          ?      509
Impacted Files Coverage Δ
dipy/workflows/docstring_parser.py 84.83% <ø> (ø)
dipy/reconst/csdeconv.py 90% <100%> (ø)

@pep8speaks
Copy link

pep8speaks commented Aug 28, 2018

Hello @skoudoro, Thank you for updating !

Line 122:37: E128 continuation line under-indented for visual indent
Line 123:37: E128 continuation line under-indented for visual indent

Comment last updated at 2019-07-23 17:40:53 UTC

@skoudoro
Copy link
Member Author

skoudoro commented Feb 1, 2019

Rebased after the #1652 merge.

@skoudoro skoudoro changed the title [WIP][fix] remove Userwarning message [Fix] remove Userwarning message Feb 1, 2019
@arokem
Copy link
Contributor

arokem commented Feb 4, 2019

Looks great. I like that you are eliminating the warning from the output, but also testing that it is being emitted. That's perfect.

Is it ready to go, from your side, or is this still WIP?

@skoudoro
Copy link
Member Author

skoudoro commented Feb 4, 2019

It seems that tests are still failing on python2.7 which surprise me.

So I just need to fix this point.

@arokem
Copy link
Contributor

arokem commented Feb 4, 2019

Looks like a float/int division thing lurking somewhere.

@arokem
Copy link
Contributor

arokem commented Mar 15, 2019

Hey @skoudoro : could you please rebase this on master and fix that failure?

@skoudoro skoudoro added this to the 1.0 milestone Apr 23, 2019
@skoudoro skoudoro force-pushed the remove-userwarning branch 2 times, most recently from 6297e56 to 9d24309 Compare May 9, 2019 15:27
@skoudoro
Copy link
Member Author

Rebased and this PR is ready for a review!

@arokem
Copy link
Contributor

arokem commented Jul 23, 2019

Looks like it needs another rebase? There are some conflicts.

@skoudoro
Copy link
Member Author

Arf, thanks for the notification, will do

@skoudoro
Copy link
Member Author

ok, it seems ready to go @arokem!

@arokem
Copy link
Contributor

arokem commented Jul 24, 2019

Yep. Thanks!

@arokem arokem merged commit 70cbf33 into dipy:master Jul 24, 2019
@skoudoro skoudoro deleted the remove-userwarning branch July 24, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants