Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] remove Userwarning message #1630

Merged
merged 19 commits into from Jul 24, 2019

Conversation

@skoudoro
Copy link
Member

commented Aug 27, 2018

During Travis build or example build, There is a bunch of warning.

This PR is the first of a series that track and resolve/remove them.

@codecov-io

This comment has been minimized.

Copy link

commented Aug 27, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@51b6422). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1630   +/-   ##
=========================================
  Coverage          ?   85.41%           
=========================================
  Files             ?      119           
  Lines             ?    14299           
  Branches          ?     2243           
=========================================
  Hits              ?    12214           
  Misses            ?     1576           
  Partials          ?      509
Impacted Files Coverage Δ
dipy/workflows/docstring_parser.py 84.83% <ø> (ø)
dipy/reconst/csdeconv.py 90% <100%> (ø)
@pep8speaks

This comment has been minimized.

Copy link

commented Aug 28, 2018

Hello @skoudoro, Thank you for updating !

Line 122:37: E128 continuation line under-indented for visual indent
Line 123:37: E128 continuation line under-indented for visual indent

Comment last updated at 2019-07-23 17:40:53 UTC

@skoudoro skoudoro force-pushed the skoudoro:remove-userwarning branch from 75a142a to 48ccd3b Feb 1, 2019

@skoudoro

This comment has been minimized.

Copy link
Member Author

commented Feb 1, 2019

Rebased after the #1652 merge.

@skoudoro skoudoro changed the title [WIP][fix] remove Userwarning message [Fix] remove Userwarning message Feb 1, 2019

@arokem

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

Looks great. I like that you are eliminating the warning from the output, but also testing that it is being emitted. That's perfect.

Is it ready to go, from your side, or is this still WIP?

@skoudoro

This comment has been minimized.

Copy link
Member Author

commented Feb 4, 2019

It seems that tests are still failing on python2.7 which surprise me.

So I just need to fix this point.

@arokem

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

Looks like a float/int division thing lurking somewhere.

@arokem

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

Hey @skoudoro : could you please rebase this on master and fix that failure?

@skoudoro skoudoro added this to the 1.0 milestone Apr 23, 2019

@skoudoro skoudoro force-pushed the skoudoro:remove-userwarning branch 2 times, most recently from 6297e56 to 9d24309 May 8, 2019

@skoudoro skoudoro force-pushed the skoudoro:remove-userwarning branch from 9d24309 to 2fb60e3 Jul 1, 2019

@skoudoro skoudoro force-pushed the skoudoro:remove-userwarning branch from 2fb60e3 to c5c64d2 Jul 17, 2019

@skoudoro

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2019

Rebased and this PR is ready for a review!

@arokem

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

Looks like it needs another rebase? There are some conflicts.

@skoudoro

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2019

Arf, thanks for the notification, will do

@skoudoro skoudoro force-pushed the skoudoro:remove-userwarning branch from 13e4bf5 to 65d645a Jul 23, 2019

@skoudoro

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2019

ok, it seems ready to go @arokem!

@arokem

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

Yep. Thanks!

@arokem arokem merged commit 70cbf33 into nipy:master Jul 24, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skoudoro skoudoro deleted the skoudoro:remove-userwarning branch Jul 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.