-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] remove Userwarning message #1630
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1630 +/- ##
=========================================
Coverage ? 85.41%
=========================================
Files ? 119
Lines ? 14299
Branches ? 2243
=========================================
Hits ? 12214
Misses ? 1576
Partials ? 509
|
Hello @skoudoro, Thank you for updating !
Comment last updated at 2019-07-23 17:40:53 UTC |
75a142a
to
48ccd3b
Compare
Rebased after the #1652 merge. |
Looks great. I like that you are eliminating the warning from the output, but also testing that it is being emitted. That's perfect. Is it ready to go, from your side, or is this still WIP? |
It seems that tests are still failing on python2.7 which surprise me. So I just need to fix this point. |
Looks like a float/int division thing lurking somewhere. |
Hey @skoudoro : could you please rebase this on master and fix that failure? |
6297e56
to
9d24309
Compare
9d24309
to
2fb60e3
Compare
2fb60e3
to
c5c64d2
Compare
Rebased and this PR is ready for a review! |
Looks like it needs another rebase? There are some conflicts. |
Arf, thanks for the notification, will do |
13e4bf5
to
65d645a
Compare
ok, it seems ready to go @arokem! |
Yep. Thanks! |
During Travis build or example build, There is a bunch of warning.
This PR is the first of a series that track and resolve/remove them.