-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test for new error in IVIM #1683
Conversation
dipy/reconst/tests/test_ivim.py
Outdated
N = len(bvals_b0t) | ||
bvecs = generate_bvecs(N) | ||
gtab = gradient_table(bvals_b0t, bvecs.T) | ||
assert_raises(ValueError, IvimModel, gtab) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is throwing the new error? I suspect it might be throwing this one first: https://github.com/nipy/dipy/blob/master/dipy/reconst/ivim.py#L216
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arokem I think you are right! I did not realize this.. Will refactor and update ASAP :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arokem Checked the error and also added an assert
to make sure that its the correct error! Does this work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! +1 for the merge from me, if the CI comes back green.
Codecov Report
@@ Coverage Diff @@
## master #1683 +/- ##
==========================================
+ Coverage 84.1% 84.16% +0.05%
==========================================
Files 113 113
Lines 13508 13508
Branches 2125 2125
==========================================
+ Hits 11361 11369 +8
+ Misses 1650 1642 -8
Partials 497 497
|
Can you update the examples too? (Doc/example/reconst_ivim.py). It's failing with the new error. You can use this as a example for your test |
@skoudoro.. Thank you for this! Will do this.. |
LGTM, waiting for the CI before merging it. |
CI's green and happy, merging! |
PR for fix #1682