[FIX] Python 3 compatibility for some tools script #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you are still retaining Python 2 compatibility. Should we just go ahead and convert this to drop Python 2 support? That way, we can get rid of the |
|
sounds good, I am ok with that |
|
LGTM. If no one else has any issues, I can merge this in a couple of days. |
Codecov Report
@@ Coverage Diff @@
## master #1738 +/- ##
=======================================
Coverage 84.26% 84.26%
=======================================
Files 115 115
Lines 13606 13606
Branches 2144 2144
=======================================
Hits 11465 11465
Misses 1643 1643
Partials 498 498 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just an update of some useful script because they were only compatible with python 2...
I used the opportunity to fix some pep8.