Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Refactoring the stats module #1861

Closed
wants to merge 2 commits into from
Closed

Conversation

arokem
Copy link
Contributor

@arokem arokem commented Jun 19, 2019

This is some work towards a unified API for statistics along bundles. For now, I am focusing on separating the analysis logic from file I/O. Still very much work in progress.

@pep8speaks
Copy link

Hello @arokem, Thank you for submitting the Pull Request !

Line 266:22: E127 continuation line over-indented for visual indent

Do see the DIPY coding Style guideline

@codecov-io
Copy link

Codecov Report

Merging #1861 into master will decrease coverage by 0.73%.
The diff coverage is 11.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1861      +/-   ##
==========================================
- Coverage   84.31%   83.57%   -0.74%     
==========================================
  Files         117      117              
  Lines       14234    14242       +8     
  Branches     2251     2251              
==========================================
- Hits        12001    11903      -98     
- Misses       1716     1817     +101     
- Partials      517      522       +5
Impacted Files Coverage Δ
dipy/stats/analysis.py 38.81% <11.76%> (-36.19%) ⬇️
dipy/workflows/stats.py 61.6% <0%> (-30.4%) ⬇️
dipy/viz/__init__.py 80% <0%> (-10%) ⬇️
dipy/viz/regtools.py 32% <0%> (-4.8%) ⬇️
dipy/utils/optpkg.py 69.56% <0%> (-4.35%) ⬇️
dipy/io/vtk.py 12.5% <0%> (-2.09%) ⬇️
dipy/viz/panel.py 81.69% <0%> (-1.41%) ⬇️
dipy/viz/app.py 51.96% <0%> (-0.4%) ⬇️

@skoudoro skoudoro added this to the 1.1 milestone Jul 26, 2019
@skoudoro
Copy link
Member

Look like we need to push this for the next release. I will update the tag

@skoudoro skoudoro modified the milestones: 1.1, 1.2 Oct 14, 2019
@skoudoro skoudoro mentioned this pull request Apr 3, 2020
22 tasks
@arokem
Copy link
Contributor Author

arokem commented Apr 9, 2020

Superseded by #2088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants