BF - fix eudx tracking for npeaks=1

[gabknight]

This addresses #1807

• The last peak was always incorrectly missing. This was especially visible when there was a single peak...
• Added a test for it.

[pep8speaks]

Hello @gabknight, Thank you for updating !

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated at 2019-07-09 08:44:16 UTC

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@c8176ac). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1888   +/-   ##
=========================================
  Coverage          ?   85.32%           
=========================================
  Files             ?      118           
  Lines             ?    14224           
  Branches          ?     2236           
=========================================
  Hits              ?    12136           
  Misses            ?     1577           
  Partials          ?      511

[skoudoro]

Since you are looking at Eudx, is the following issue still relevant: #325?

[gabknight]

Since you are looking at Eudx, is the following issue still relevant: #325?

@skoudoro EuDX(.) will now be LocalTracking(.) and PeaksAndMetricDG will get the needed information directly from the PeaksAndMetric object. So the specific error should not happen.

However, this does not clarify the cython ValueError from dipy.tracking.propspeed.eudx_both_directions(.) that @Garyfallidis mentioned (which is also used by PeaksAndMetricDG).

So might want to close this issue, and make a new general one on better handling of cython ValueError.

[arokem]

I think this is ready to go? @skoudoro : do you agree? Or is your comment still something that needs too be addressed here?

[skoudoro]

Agree, you can merge it! I just need to create a new issue and close #325 as gab suggested. will do later