Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dipy.io.trackvis #1942

Merged
merged 6 commits into from
Aug 1, 2019
Merged

Remove dipy.io.trackvis #1942

merged 6 commits into from
Aug 1, 2019

Conversation

skoudoro
Copy link
Member

The module dipy.io.trackvis was deprecated since the 0.14.0 release. This PR remove this module and update all the necessary files

@skoudoro skoudoro added this to the 1.0 milestone Jul 30, 2019
@pep8speaks
Copy link

pep8speaks commented Jul 30, 2019 •
edited
Loading

Hello @skoudoro, Thank you for updating !

Line 106:1: E402 module level import not at top of file
Line 107:1: E402 module level import not at top of file
Line 216:1: E402 module level import not at top of file
Line 217:1: E402 module level import not at top of file

Comment last updated at 2019-08-01 15:04:32 UTC

Garyfallidis
Garyfallidis reviewed Aug 1, 2019
View reviewed changes
doc/examples/segment_quickbundles.py Outdated

streamlines = [i[0] for i in streams]
streamlines = Streamlines(fornix)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be streamlines = fornix?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or the load_tractogram().streamlines directly

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a tutorial, I just wanted to be explicit for the user. So now, it is:
streamlines = fornix.streamlines

Garyfallidis
Garyfallidis reviewed Aug 1, 2019
View reviewed changes
doc/examples/segment_extending_clustering_framework.py Outdated
fornix = load_tractogram(fname, 'same',
bbox_valid_check=False).streamlines

streamlines = Streamlines(fornix)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be streamlines=fornix?

Garyfallidis
Garyfallidis reviewed Aug 1, 2019
View reviewed changes
doc/examples/segment_clustering_metrics.py Outdated
fornix = load_tractogram(fname, 'same',
bbox_valid_check=False).streamlines

streamlines = Streamlines(fornix)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see below

@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@4de2d70). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1942   +/-   ##
=========================================
  Coverage          ?   82.95%           
=========================================
  Files             ?      117           
  Lines             ?    14620           
  Branches          ?     2321           
=========================================
  Hits              ?    12128           
  Misses            ?     1950           
  Partials          ?      542
Impacted Files Coverage Δ
dipy/segment/clustering.py 94.63% <ø> (ø)
dipy/data/fetcher.py 34.92% <0%> (ø)

1 similar comment
@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@4de2d70). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1942   +/-   ##
=========================================
  Coverage          ?   82.95%           
=========================================
  Files             ?      117           
  Lines             ?    14620           
  Branches          ?     2321           
=========================================
  Hits              ?    12128           
  Misses            ?     1950           
  Partials          ?      542
Impacted Files Coverage Δ
dipy/segment/clustering.py 94.63% <ø> (ø)
dipy/data/fetcher.py 34.92% <0%> (ø)

@Garyfallidis Garyfallidis merged commit dcbf84f into dipy:master Aug 1, 2019
@skoudoro skoudoro deleted the remove-trackvis branch August 7, 2019 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garyfallidis Garyfallidis Garyfallidis left review comments

@frheault frheault frheault left review comments

Assignees
No one assigned
Labels
state: needs code review type:Maintenance
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@skoudoro @pep8speaks @Garyfallidis @frheault