Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maxime's [Gallery] Reconst DTI example revisited #204

Merged
merged 17 commits into from
Jul 10, 2013

Conversation

Garyfallidis
Copy link
Contributor

Hello,

I have rebased and fixed some conflicts with this PR. This is replacing #193.

@Garyfallidis
Copy link
Contributor Author

Alright, I believe this is now ready to be merged!

nib.save(fa_img, 'tensor_fa.nii.gz')

"""
You can now see the result with any nifti viewer or check it slice by slice
using matplotlib_'s imshow. In the same way you can save the eigen values the
using matplotlib_'s imshow. In the same way you can save the eigen values, the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might have originally been my error, but I believe "eigenvalues" s.b. one word.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no clue. I have seen all three case eigen-values, eigen values and eigenvalues. I am happy to change this to eigenvalues.

@arokem
Copy link
Contributor

arokem commented Jun 20, 2013

In general - this is a great improvement. I will try to build upon this in
the work for the paper. I just had a couple of comments questions.

On Thu, Jun 20, 2013 at 7:00 AM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

Alright, I believe this is now ready to be merged!


Reply to this email directly or view it on GitHubhttps://github.com//pull/204#issuecomment-19754295
.

nib.save(evecs_img, 'tensor_evecs.nii.gz')

"""
Now, lets get the tensor coefficients D and format them for them
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and format them for them? I don't really get it, is it a typo?

@Garyfallidis
Copy link
Contributor Author

This PR is ready to be merged.

@stefanv
Copy link
Contributor

stefanv commented Jun 25, 2013

@Garyfallidis Done responding to @arokem? @arokem Happy with current status?

@Garyfallidis
Copy link
Contributor Author

Hi @stefanv. Good point. I have responded to Ariel's concerns. At least as much as I could. Basically, I am not proficient to answer his question about using or not an utility function to save the symmetric tensors. I think this is more a question for @matthew-brett and @MrBago. Thank you for bringing it up.

@Garyfallidis
Copy link
Contributor Author

Hello, after some good thought it seems that the first dipy tutorial which is this one (reconst_dti.py) should be all about dipy functions. In another PR will update this example with tensor visualization (I am on it :)) not only odf visualization with the fvtk plugin. We will try to make a fibernav-dipy specific tutorial with @mdesco and add some external functions for fibernav in dipy.external or dipy.io. As we did for fsl. If someone has more thoughts on how we could save the tensors to support most of the platforms around please do that in a different PR. Can someone go ahead and merge this PR as all comments have been now addressed?

arokem added a commit that referenced this pull request Jul 10, 2013
Maxime's [Gallery] Reconst DTI example revisited
@arokem arokem merged commit 1416d87 into dipy:master Jul 10, 2013
@arokem
Copy link
Contributor

arokem commented Jul 10, 2013

Hooray!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants