BF: fixed problem with NANs in odfdeconv

[Garyfallidis]

Added tests and fix for calculation of odf_deconv when NANs are present.
This was identified by Dr. Jan Schreiber as reported in the mailing list. See discussion here: http://mail.scipy.org/pipermail/nipy-devel/2014-August/010419.html

[arokem]

You might also go with:

if np.any(np.isnan(odf_sh)):

I find that slightly clearer

[arokem]

Do you understand under what conditions nan appears here?

[Garyfallidis]

Yeah, it's division by zero. When the odf_sh is divided by Z.

[arokem]

Cool - maybe add a comment on the first line of the function, right before
if np.any(np.isnan(...?

On Wed, Aug 13, 2014 at 12:06 PM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

Yeah, it's division by zero. When the odf_sh is divided by Z.

—
Reply to this email directly or view it on GitHub
#407 (comment).

[Garyfallidis]

I think it speaks by itself no?

[arokem]

I don't think so, which is why I asked (but I am generally quite slow). I suggest something like:

# odf_sh is divided by Z, in ConstrainedSphericalDeconvModel.fit, which sometimes contains 0's 

Did I get that right?

[Garyfallidis]

Nearly, there @arokem. This affects only the Sharpening Deconvolution transform not the CSD.

Happy?

[arokem]

Yes - very happy