Fix evolution save win32 #469
Conversation
| @@ -61,6 +61,7 @@ def test_rigid_parallel_lines(): | |||
| bundle_initial = simulated_bundle() | |||
| bundle, shift = center_streamlines(bundle_initial) | |||
| mat = compose_matrix44([20, 0, 10, 0, 40, 0]) | |||
|
|
|||
There was a problem hiding this comment.
Not a problem for this PR, but for my taste, and for PEP8 - there are lots of extra blank lines. You monitor may be bigger than mine, and I bet your eyesight is better and fontsize smaller, but the extra whitespace makes the code harder for me to read.
There was a problem hiding this comment.
Okay true. I have to remove some spaces. But because PEP8 is good you can merge this PR. I am working right now on another small extension PR for the Streamline-based Registration and I can remove unneeded spaces in this one. I hope that this sounds good for you. Let me know otherwise.
There was a problem hiding this comment.
Yes, sure, no need to hold up the PR for the blank lines, it was just something I noticed.
PEP8 says 'Use blank lines in functions, sparingly, to indicate logical sections.'.
I know it's a matter of taste, and I'm not generally a huge PEP8 person, but lots of blank lines does look distracting to me, makes it harder to follow the flow.
|
Looks good to me. |
MRG: Fix evolution save win32 Use lists instead of files to track progress of optimizer. This should resolve issue #467.
|
I agree completely with what you say. Blank lines should be used to separate logical regions. It helps a lot. Will do the change for sure :) Thx again for the feedback. But please also tell me when you find some time what is a safe way to save tmp files during object deletion. |
|
You just have to make sure that you have delete any objects that could possibly be holding onto these file objects before you delete the files, in Windows. It can be difficult to tell though. In practice, I end up logging into a Windows machine and futzing with deleting objects ( We also have the fab |
|
Yes, I would love to know about try_branch.py |
|
Wrote up instructions here : https://github.com/nipy/nibotmi/blob/master/install.rst#trying-a-set-of-changes-on-the-buildbots |
|
Super-useful! Thanks for doing that. On Wed, Nov 19, 2014 at 11:36 AM, Matthew Brett notifications@github.com
|
|
De nada - let me know if it doesn't work right - the whole try branch mechanism is a bit delicate in buildbot. |
This should resolve issue #467.