Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove npymath library from cython extensions #527
When numpy is built with mingw, the npy_* functions exported from libnpymath.a reference some runtime math functions whose name has a leading underscore, like:
This PR removes the npymath library from the linking step of the cython extensions, and defines the required subset of math functions in dpy_math.h (by borrowing some code directly from numpy).
With the proposed modification, the conflicting buildbots now pass:
Yes, I tried yesterday on the two conflicting buildbots, and all the green ones, just to be sure we didn't break anything (we didn't). Now I'm trying with the new modifications.
What about explicitly requesting manifest creation to msvc? to prevent the checker from failing with versions 10.0+: