New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NF: Fetch and Read the MNI T1 and/or T2 template. #680

Merged
merged 1 commit into from Jul 16, 2015

Conversation

Projects
None yet
2 participants
@arokem
Member

arokem commented Jul 15, 2015

While I was there, I did a bit of PEP8 cleaning and functionalized some repeated boiler-plate.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Jul 16, 2015

Nice job!

Garyfallidis added a commit that referenced this pull request Jul 16, 2015

Merge pull request #680 from arokem/fetch-mni
NF: Fetch and Read the MNI T1 and/or T2 template.

@Garyfallidis Garyfallidis merged commit e4ef25f into nipy:master Jul 16, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Jul 16, 2015

@villalonreina you can now update this file to also download the tissue maps from MNI.
Also @arokem do we need to add some license info for these?

@arokem

This comment has been minimized.

Member

arokem commented Jul 16, 2015

License info is included! But let me know if this seems insufficient, and
we'll fix:

https://github.com/nipy/dipy/blob/master/dipy/data/fetcher.py#L567
https://github.com/nipy/dipy/blob/master/dipy/data/fetcher.py#L586

On Thu, Jul 16, 2015 at 11:02 AM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

@villalonreina https://github.com/villalonreina you can now update this
file to also download the tissue maps from MNI.
Also @arokem https://github.com/arokem do we need to add some license
info for these?


Reply to this email directly or view it on GitHub
#680 (comment).

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Jul 16, 2015

We need to add a printout to say that by downloading this dataset you agree to this license found there... or something.

@arokem

This comment has been minimized.

Member

arokem commented Jul 16, 2015

Note that I have mirrored all the files here:

https://digital.lib.washington.edu/researchworks/bitstream/handle/1773/33312/

so that we can grab individual files, rather than a big archive with all of
them.

On Thu, Jul 16, 2015 at 11:04 AM, Ariel Rokem arokem@gmail.com wrote:

License info is included! But let me know if this seems insufficient, and
we'll fix:

https://github.com/nipy/dipy/blob/master/dipy/data/fetcher.py#L567
https://github.com/nipy/dipy/blob/master/dipy/data/fetcher.py#L586

On Thu, Jul 16, 2015 at 11:02 AM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

@villalonreina https://github.com/villalonreina you can now update
this file to also download the tissue maps from MNI.
Also @arokem https://github.com/arokem do we need to add some license
info for these?


Reply to this email directly or view it on GitHub
#680 (comment).

@arokem

This comment has been minimized.

Member

arokem commented Jul 16, 2015

Read the license - I don't think it requires that.

On Thu, Jul 16, 2015 at 11:06 AM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

We need to add a printout to say that by downloading this dataset you
agree to this license found there... or something.


Reply to this email directly or view it on GitHub
#680 (comment).

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Jul 16, 2015

Okay. Maybe they want us to cite some of their papers?

@arokem

This comment has been minimized.

Member

arokem commented Jul 16, 2015

Yes - we should do that. Adding.

On Thu, Jul 16, 2015 at 11:08 AM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

Okay. Maybe they want us to cite some of their papers?


Reply to this email directly or view it on GitHub
#680 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment