New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RF + DOC: Add MNI template reference. Also import it into the dipy.da… #681
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e618ea6
RF + DOC: Add MNI template reference. Also import it into the dipy.da…
arokem 81596eb
DOC: More details: license, and link to the original MNI website.
arokem c900534
DOC: Deal with some non-unicode characters.
arokem 88bb115
RF: Used fetch_data for the MNI template fetchers.
arokem File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @arokem, why do you prefer the ICBM152 2009a version and not the 2009c version?
http://www.bic.mni.mcgill.ca/ServicesAtlases/ICBM152NLin2009
Also now that you are on it can you also fetch the rest of the maps PDs etc?
We can definitely use them for other projects like the Tissue classifiers etc.
I would recommend fetching the 1x1x1 atlases but also fetching the 0.5x0.5x0.5
atlases those will be useful for performing high resolution anatomical tracking.
I hope this is not much to ask. It would be great to fetch the IIT atlas too at some point.
I will need to ask permission from Arfanakis for that. But I think it's possible!
Exciting!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'c' atlas is symmetric, and so does not represent an average brain. It's main use is when you want to compare directly between the two hemispheres, so I don't think it should be the default.
It sounds like the IIT atlas has an inconvenient license, so we should be careful when fetching that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt about that @matthew-brett It clearly says in the MNI website
http://www.bic.mni.mcgill.ca/ServicesAtlases/ICBM152NLin2009
that there is a symmetric and asymmetric version of the 'c' atlas.
Look at the last bullet point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know well the person who wrote the atlas and I don't think he had the intention to have a hard-boiled license. I will speak to him about that. Maybe they would love to update their license. Or they don't mind fetching it in DIPY.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes - sorry - you are right about 2009c. Then - do you know the difference between 2009a and 2009c? The page mentions only the different version numbers for the intensity correction method and different 'resampling'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No rush. The ROIs that we are using for tractography segmentation are all
based on the MNI template anyway.
On Thu, Aug 6, 2015 at 10:18 AM, Samuel St-Jean notifications@github.com
wrote:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(that might also be the reason we are using 'a')
On Thu, Aug 6, 2015 at 10:20 AM, Ariel Rokem arokem@gmail.com wrote:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no preference for a as oppose to c. If c is better, let's go with
that
On Thursday, August 6, 2015, Ariel Rokem notifications@github.com wrote:
Jason D. Yeatman, PhD
Assistant Professor, Institute for Learning & Brain Sciences (I-LABS)
Department of Speech & Hearing Sciences
University of Washington
http://depts.washington.edu/bdelab/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably the ROIs were made based on 'a'?
On Thu, Aug 6, 2015 at 11:03 AM, Jason D. Yeatman notifications@github.com
wrote:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guys, you can fetch both and check if the ROIs correspond.