Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH+BF: find_files to take list of topdirs, look for _bold only under sub-* directories #496

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

yarikoptic
Copy link
Member

Originally issue reported on
https://neurostars.org/t/heudicov-permission-denied-bids-derivatives-mriqc/16543
where heudiconv would crash while trying to create an _events.tsv file under derivatives/mriqc.

heudiconv should not care to look anywhere besides immediate subject directories, even if people
place derivatives direcly in the dataset into which they are also converting their data into
(making YODA unhappy).

TODOs

  • verify on a sample case that there is no side effect (not sure if I would be up for composing a test)

… sub-* directories

Originally issue reported on
https://neurostars.org/t/heudicov-permission-denied-bids-derivatives-mriqc/16543
where heudiconv would crash while trying to create an _events.tsv file under derivatives/mriqc.

heudiconv should not care to look anywhere besides immediate subject directories, even if people
place derivatives direcly in the dataset into which they are also converting their data into
(making YODA unhappy).
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #496 (2e1e1d3) into master (0e0f9e3) will increase coverage by 0.81%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
+ Coverage   76.01%   76.82%   +0.81%     
==========================================
  Files          38       40       +2     
  Lines        3010     3094      +84     
==========================================
+ Hits         2288     2377      +89     
+ Misses        722      717       -5     
Impacted Files Coverage Δ
heudiconv/bids.py 83.06% <100.00%> (ø)
heudiconv/parser.py 92.70% <100.00%> (+0.31%) ⬆️
heudiconv/tests/test_main.py 100.00% <0.00%> (ø)
heudiconv/tests/test_dicoms.py 100.00% <0.00%> (ø)
heudiconv/tests/test_convert.py 100.00% <0.00%> (ø)
heudiconv/tests/test_heuristics.py 100.00% <0.00%> (ø)
heudiconv/heuristics/bids_PhoenixReport.py 93.33% <0.00%> (ø)
heudiconv/heuristics/test_b0dwi_for_fmap.py 92.30% <0.00%> (ø)
heudiconv/utils.py 90.32% <0.00%> (+0.40%) ⬆️
heudiconv/dicoms.py 82.11% <0.00%> (+0.96%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e0f9e3...2e1e1d3. Read the comment docs.

@yarikoptic
Copy link
Member Author

AFAIK should be ok to go

@yarikoptic yarikoptic merged commit 6b80704 into nipy:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant