Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH+BF: consistent n/a for age/sex, also handle ?M for months #500

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

yarikoptic
Copy link
Member

Also initiated test_bids.py to finally start collecting testing of
BIDS specific logic we add

Closes #499

Also initiated test_bids.py to finally start collecting testing of
BIDS specific logic we add

Closes nipy#499
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #500 (ad75d50) into master (6b80704) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
+ Coverage   76.82%   77.07%   +0.24%     
==========================================
  Files          40       41       +1     
  Lines        3094     3127      +33     
==========================================
+ Hits         2377     2410      +33     
  Misses        717      717              
Impacted Files Coverage Δ
heudiconv/bids.py 84.46% <100.00%> (+1.39%) ⬆️
heudiconv/tests/test_bids.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b80704...ad75d50. Read the comment docs.

@yarikoptic yarikoptic requested review from satra and mgxd March 26, 2021 21:42
@yarikoptic
Copy link
Member Author

@satra @mgxd @pvelasco I would appreciate a review if you have a moment

@yarikoptic yarikoptic merged commit 711d403 into nipy:master Mar 29, 2021
@yarikoptic yarikoptic deleted the bf-participant-nas branch April 20, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Participants.tsv will null values
2 participants