Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create/populate .bidsignore with .git (if datalad mode?) and .heudiconv #515

Open
yarikoptic opened this issue Jun 16, 2021 · 6 comments
Open

Comments

@yarikoptic
Copy link
Member

yarikoptic commented Jun 16, 2021

It seems that many BIDS tools might look outside of the standardized by BIDS locations, and thus end up in .git or in .heudiconv and then complain about their hard destiny. (e.g. nipreps/fmriprep#2426 but user followed up with complaints about .heudiconv after datalad clean).

To prevent that from happening I think we should just populate in bids mode .bidsignore with all those non-interesting locations:

.git
.datalad
.heudiconv

where no bids tool should look under... or may be it should just become .*? unfortunately .bidsignore is not part of the BIDS standard (see discussion bids-standard/bids-specification#131) so the "utility" from it might be limited...

@effigies
Copy link
Member

Yes, .bidsignore is specifically a validator solution. The problem is that ignoring could either mean "ignore file" or "ignore errors related to file". In the validator it's the same, in other tools, it's ambiguous.

It might make sense to put .heudiconv into .gitignore, so that it never enters the dataset, though perhaps that's also not desirable.

@mgxd
Copy link
Member

mgxd commented Jun 23, 2021

alternatively, we could stick .heudiconv/ into <bids-root>/code in the case of BIDS conversions

@effigies
Copy link
Member

Is it code or provenance?

@mgxd
Copy link
Member

mgxd commented Jun 23, 2021

I think it falls in line with the definition of what it's intended for the spec, specifically

conversion from the format of the source data to the BIDS format

@effigies
Copy link
Member

Seems reasonable, then. Found one in my cache to look at, and it looks like it may also potentially include private data, which is not ideal for publication.

@yarikoptic
Copy link
Member Author

It might make sense to put .heudiconv into .gitignore, so that it never enters the dataset, though perhaps that's also not desirable.

ATM I do keep that content under git in the same repo or under submodule. Adding it to .gitignore would complicate managing it. Indeed, those could leak protected data, thus should be added under git-annex and not shared.

Is it code or provenance?

both. .py copies of heuristic are "code". .txt etc -- pure provenance to establish provenance of the conversion to e.g. later locate that data on a server elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants