New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIssing plots in granger_fmri.html #173
Comments
Thanks for spotting this. Looks like a lot of nan's in the results from Granger Causality calculation. Since it's been a while since the docs were built, I'll probably need to bisect back in history to see where this happened. Unfortunately, it might take me a little while to get to it. |
The documentation web site still has blank pages, and the HTTP headers show
$ wget -S http://nipy.org/nitime/examples/granger_fmri.html--2019-07-04
08:16:37-- http://nipy.org/nitime/examples/granger_fmri.html
Resolving nipy.org (nipy.org)... 185.199.110.153, 185.199.109.153,
185.199.111.153, ...
Connecting to nipy.org (nipy.org)|185.199.110.153|:80... connected.
HTTP request sent, awaiting response...
HTTP/1.1 200 OK
Server: GitHub.com
Content-Type: text/html; charset=utf-8
Last-Modified: Sat, 22 Jun 2019 22:01:11 GMT
Sorry for the reopen if the web page regeneration is done
automatically and I am just jumping the gun.
…
|
Yeah. I still haven't had time to look into this...
…On Thu, Jul 4, 2019 at 5:40 AM justbennet ***@***.***> wrote:
The documentation web site still has blank pages, and the HTTP headers show
$ wget -S http://nipy.org/nitime/examples/granger_fmri.html--2019-07-04
08:16:37-- http://nipy.org/nitime/examples/granger_fmri.html
Resolving nipy.org (nipy.org)... 185.199.110.153, 185.199.109.153,
185.199.111.153, ...
Connecting to nipy.org (nipy.org)|185.199.110.153|:80... connected.
HTTP request sent, awaiting response...
HTTP/1.1 200 OK
Server: GitHub.com
Content-Type: text/html; charset=utf-8
Last-Modified: Sat, 22 Jun 2019 22:01:11 GMT
Sorry for the reopen if the web page regeneration is done
automatically and I am just jumping the gun.
On Wed, Jul 3, 2019 at 11:01 PM Ariel Rokem ***@***.***>
wrote:
>
> Closed #173 via #176.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#173?email_source=notifications&email_token=AAA46NTADJKKGSOTPJRANK3P5XVVTA5CNFSM4H27ZHF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZHJ3MQ#issuecomment-508468658>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAA46NUH7U3M7VEYGOBFEUDP5XVVTANCNFSM4H27ZHFQ>
.
|
Thanks. Just curious because the issue got closed but the problem seems to remain...? There is also a question on the Neuroimaging mailing list about it, Subject: [Neuroimaging] GC analysis with nitime Should the issue be reopened until it gets addressed? |
Clearly. |
Hi, I had the same issue when trying to run the Granger causality example for fMRI on my own computer. I tried rolling back to older versions of nitime (0.7, 0.6, and 0.5) but they had their own problems with dependent packages. Is there any way on my end to make the Granger causality module functional? It is exactly the tool I am looking for in my research. Thanks. |
Hi all, The
Note the order is While in making the plot,
So we ended up with nothing. I suppose the fix is to transpose the ordering in
This gives the following image for the
But, I'm not familiar with the plotting conventions people use in such like of analyses. Do we assume the plot in |
Thanks for figuring this out! I think that the best fix would probably be to alter the behavior of |
@arokem I'm not sure what exact changes to make to |
Gotcha. Yeah - I think that your original solution makes more sense then. Arguably, this is the design we should have implemented to begin with. Could you make a PR with that implemeted? |
@arokem It seems that the fix is failing the |
Yes - we need to adjust the test and warn about the break to backwards compatibility. If you reopen the PR, we can discuss that there. |
I made some back-n-forth changes, hopefully not creating too much confusion to the git history. |
Closed through #193 |
There might be something not right about the last two figures here
Those are missing the body of the graph, which is all white.
I believe this is in the file
doc/examples/granger_fmri.py
.The text was updated successfully, but these errors were encountered: