Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the LazyImport jig pickleable #103

Closed
wants to merge 2 commits into from

Conversation

ivanov
Copy link
Member

@ivanov ivanov commented Jun 7, 2012

I believe this closes #102 - and it retains the documentation of the LazyImport machinery

@arokem
Copy link
Member

arokem commented Jun 7, 2012

Yep! That seems to do the trick. I will merge it in.

Thanks so much for taking a look so quickly!

By the way - I am planning to cut a release sometime next week. Does that work OK for you?

@arokem arokem closed this Jun 7, 2012
@ivanov ivanov reopened this Jun 7, 2012
@ivanov
Copy link
Member Author

ivanov commented Jun 7, 2012

did you close my request by accident?

@arokem
Copy link
Member

arokem commented Jun 7, 2012

Oh - sorry! I didn't know you were still at it, so I thought I would merge and close.

Note that I made a really small commit, making a change to one of the docstrings in viz.py, so you might have to rebase on top of that, before you merge your additional commit.

Again - thanks a lot for taking a look so quickly!

@ivanov ivanov closed this in d7b7226 Jun 7, 2012
@ivanov
Copy link
Member Author

ivanov commented Jun 7, 2012

ok, I put it all in master. Next week for cutting a release works fine for me, I'll very busy the rest of this week, but will be happy to pitch in and help you cut one next week. (I'd love to actually go through the process with you to learn about what needs doing for a release, if that's ok)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sphinx docs won't build (related to lazyimports?)
2 participants