Index at bug #36
Merged
Index at bug #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'index_at seems to fail with negative times'
|
Code and fix look clean to me, thanks! I'd just add a small comment (or in the test docstring) indicating there that the bug was specifically with incorrect handling of negative t0 (so that we can know later without hunting down mailing list archives). This way if anything goes wrong again on this front, at least we have a hint to the kind of issue it was addressing. With that, by all means go ahead and merge/push, thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test and fix for issue 35 as reported by Jonathan Taylor on 2010-12-06