New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert interfaces #2
Conversation
sorry, I have a question, why I have added all packages needed in |
Apologies for the slow responses, I'm only just getting back to work after the conference.
We declare dependencies here: Lines 25 to 26 in 1cda476
For dependencies only required for testing, we can add them here: Lines 44 to 50 in 1cda476
|
…s into wip-yc-convert-wf
okay... the test failed again. But this time I know why! So I have something like |
@djarecka here it is |
I think we can remove 3.7 from GA, so it should work. Will merge and fix the testing in another PR |
hello @effigies, I converted
fitlins/fitlins/interfaces/abstract.py
intopydra/tasks/fitlins/interfaces/abstract.py
since the originalnistats.py
cited thisabstract.py
a lot.Would you like to take a look at it?
type
for each field correctly. I added annotations thereEstimatorOutputSpec
notFirstLevelEstimatorOutputSpec
while we do have aSecondLevelEstimatorOutputSpec
Thanks!