Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert interfaces #2

Merged
merged 35 commits into from Sep 12, 2022
Merged

convert interfaces #2

merged 35 commits into from Sep 12, 2022

Conversation

yibeichan
Copy link
Collaborator

hello @effigies, I converted fitlins/fitlins/interfaces/abstract.py into pydra/tasks/fitlins/interfaces/abstract.py since the original nistats.py cited this abstract.py a lot.
Would you like to take a look at it?

  1. I'm not sure whether I specified type for each field correctly. I added annotations there
  2. may I ask why the first level estimator output is called EstimatorOutputSpec not FirstLevelEstimatorOutputSpec while we do have a SecondLevelEstimatorOutputSpec

Thanks!

@yibeichan
Copy link
Collaborator Author

sorry, I have a question, why I have added all packages needed in requirements.txt, I still got errors no module named xxx from the test

@effigies
Copy link

effigies commented Jul 5, 2022

Apologies for the slow responses, I'm only just getting back to work after the conference.

sorry, I have a question, why I have added all packages needed in requirements.txt, I still got errors no module named xxx from the test

We declare dependencies here:

pydra-fitlins/setup.cfg

Lines 25 to 26 in 1cda476

install_requires =
pydra >= 0.6.2

For dependencies only required for testing, we can add them here:

pydra-fitlins/setup.cfg

Lines 44 to 50 in 1cda476

test =
pytest >= 4.4.0
pytest-cov
pytest-env
pytest-xdist
pytest-rerunfailures
codecov

@yibeichan yibeichan changed the title create .py files and write abstract.py convert interfaces Jul 15, 2022
@yibeichan
Copy link
Collaborator Author

okay... the test failed again. But this time I know why! So I have something like list[dict] for annotation; however, 'type' object is not subscriptable until python 3.9. That's probably the reason I failed test(3.7) and test(3.8)....
So, how should we deal with python version difference?

@yibeichan
Copy link
Collaborator Author

okay... the test failed again. But this time I know why! So I have something like list[dict] for annotation; however, 'type' object is not subscriptable until python 3.9. That's probably the reason I failed test(3.7) and test(3.8).... So, how should we deal with python version difference?

@djarecka here it is

@djarecka
Copy link
Contributor

I think we can remove 3.7 from GA, so it should work. Will merge and fix the testing in another PR

@djarecka djarecka merged commit 89056d3 into nipype:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants