update jupyterbook #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also update binder link in |
effigies
reviewed
Jul 6, 2022
|
This LGTM. Made a couple small fixes. Let's see how it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, based on our discussion in the issue #23 , I made the following changes:
jupyterbook/requirementsfromrequirements.txtand add it to ourgh-pages.ymlREADME.mdback to notebooks instead of jupyterlab interface_config.yml_config.ymlso that each chapter can launch normally in binderone more question, @effigies I only put two packages in
jupyterbook/requirementsbecause all the others seems for binder. Not sure whether I did it correctly.