Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to overwrite id='active' #11

Closed
0xgeert opened this issue Feb 24, 2015 · 3 comments
Closed

ability to overwrite id='active' #11

0xgeert opened this issue Feb 24, 2015 · 3 comments

Comments

@0xgeert
Copy link

0xgeert commented Feb 24, 2015

In a lot of circumstances id=active is not ideal. The most simplest case as having multiple sliders on the page: 2 DOM-elements end up getting id=active which is not compliant.

What about a way to overwrite this behavior, or (and this may work well enough) generate some id's and keep a list of those generated. I.e.: itemslide-1, itemslide-2. etc.

@nir9
Copy link
Owner

nir9 commented Feb 25, 2015

Yah but maybe a simpler solution would be to do class=active instead.

@0xgeert
Copy link
Author

0xgeert commented Feb 25, 2015

Yeah sure, didn't look at why you needed it. Still may I suggest using a namespaced classname such as itemslide-active instead, so it will play nice with other libraries?

@nir9
Copy link
Owner

nir9 commented Feb 25, 2015

Sure I'll add it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants