forked from wixtoolset/wix
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Include duplicated inline directory symbols referenced in subsequent …
…sections Due to the handling of redundant symbols, which are only used by inline directory syntax, the symbols were only defined in the first section encountered by the linker. Fix that so at most one duplicated inline directory symbol is included when referenced. Fixes 7840
- Loading branch information
Showing
7 changed files
with
108 additions
and
52 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
...ixToolsetTest.CoreIntegration/TestData/Directory/RedundantSubdirectoryInSecondSection.wxs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs"> | ||
<Package Name="~RedundantSubdirectories" Version="1.0.0.0" Manufacturer="Example Corporation" UpgradeCode="12E4699F-E774-4D05-8A01-5BDD41BBA127" Compressed="no"> | ||
<MajorUpgrade DowngradeErrorMessage="A newer version of [ProductName] is already installed." /> | ||
|
||
<Feature Id="ProductFeature"> | ||
<!-- NotIncludeButFirst will define the subdirectory and IncludedButSecond needs the same symbols, this tests linking order --> | ||
<ComponentGroupRef Id="IncludedButSecond" /> | ||
</Feature> | ||
</Package> | ||
|
||
<Fragment Id="NotIncludedButFirst"> | ||
<ComponentGroup Id="NotIncludedButFirst"> | ||
<Component Directory="ProgramFilesFolder" Subdirectory="a\b\c"> | ||
<File Name="notincluded.txt" Source="test.txt" /> | ||
</Component> | ||
</ComponentGroup> | ||
</Fragment> | ||
|
||
<Fragment Id="IncludedButSecond"> | ||
<ComponentGroup Id="IncludedButSecond"> | ||
<Component Directory="ProgramFilesFolder" Subdirectory="a\b\c"> | ||
<File Name="included.txt" Source="test.txt" /> | ||
</Component> | ||
</ComponentGroup> | ||
</Fragment> | ||
</Wix> |