Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Experiment with flattening graphs for textual edit distance based match #188

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

WIP: Experiment with flattening graphs for textual edit distance based match #188

wants to merge 4 commits into from

Conversation

nirizr
Copy link
Owner

@nirizr nirizr commented Feb 15, 2017 •
edited

Remaining work:

  • CONSIDER: Branches already seen should be listed again, only avoid descending?
  • Surround siblings with parentheses
  • (Optional) edit distance operations are:
    1. remove a node.
    2. add a node.
    3. swap two siblings, only full content and surrounding parentheses.
    4. replace all occurrences of a node with another.

Signed-off-by: Nir Izraeli nirizr@gmail.com

@nirizr nirizr force-pushed the nirizr/graph_flatten_for_editdistance branch 6 times, most recently from fb07f5c to 7b48939 Compare February 18, 2017 15:09
nirizr
nirizr commented Feb 23, 2017
View reviewed changes
idaplugin/rematch/collectors/flat_graph.py Outdated

def _append_bbs(self, *bbs):
for bb in bbs:
self.items.append(self._bb_value(bb))
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.items.extend(map(self._bb_value, bbs))

@nirizr nirizr force-pushed the nirizr/graph_flatten_for_editdistance branch 3 times, most recently from eeadbb7 to 1b77c7e Compare February 28, 2017 09:12
@nirizr nirizr self-assigned this Mar 20, 2017
@nirizr nirizr removed their assignment Jun 15, 2017
@nirizr nirizr force-pushed the nirizr/graph_flatten_for_editdistance branch from 1b77c7e to d310f57 Compare June 18, 2017 19:32
@nirizr nirizr added the WIP label Jun 18, 2017
@nirizr nirizr force-pushed the nirizr/graph_flatten_for_editdistance branch 2 times, most recently from 28e8995 to c07cd14 Compare June 19, 2017 17:22
@nirizr nirizr force-pushed the nirizr/graph_flatten_for_editdistance branch 4 times, most recently from 9bc383f to 5c7c5b7 Compare September 29, 2017 17:57
@nirizr
Experiment with flattening graphs for textual edit distance based match
3dcfe65 
Signed-off-by: Nir Izraeli <nirizr@gmail.com>
@nirizr
Connect new flag graph vector to plugin
4b784bd 
Signed-off-by: Nir Izraeli <nirizr@gmail.com>
@nirizr
fix flat graph after rebase
5916681 
Signed-off-by: Nir Izraeli <nirizr@gmail.com>
@nirizr
Rename class and file
ba071d5 
Signed-off-by: Nir Izraeli <nirizr@gmail.com>
@nirizr nirizr force-pushed the nirizr/graph_flatten_for_editdistance branch from 5c7c5b7 to ba071d5 Compare December 17, 2017 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do not merge match engine WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nirizr