-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pluggable serialization #14
Conversation
import java.lang.reflect.Method; | ||
import java.util.Map; | ||
|
||
public class JsonSerializerMapper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want this to be public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure - it might be useful
@@ -92,10 +91,10 @@ public TaskExecution newTaskExecution(WorkflowManager workflowManager, Executabl | |||
|
|||
List<Set<TaskId>> sets = taskExecutor.getChecker().getSets(); | |||
List<Set<TaskId>> expectedSets = Arrays.<Set<TaskId>>asList | |||
( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: fuzz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't get IntelliJ to match my quixotic style.
|
@@ -92,6 +94,8 @@ public void testPriority() throws Exception | |||
.withCurator(curator, "test", "1") | |||
.build() ) | |||
{ | |||
Scheduler.debugQueuedTasks = new Semaphore(0); | |||
((WorkflowManagerImpl)workflowManager).debugDontStartConsumers = true; // make sure all tasks are added to ZK before they start getting consumed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! this fixed a flake I had a less effective workaround to :)
No description provided.