Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Environment variables instead of hardcoded values for API urls and keys #84

Closed
nirvanaitsolutions opened this issue Feb 6, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@nirvanaitsolutions
Copy link
Owner

Is your feature request related to a problem? Please describe.
Keeping the environment variables in the codebase is a bad practice and highly prone to a security attack if exploited.

Describe the solution you'd like
A We want all the environment variables to be loaded from an environment config.

Describe alternatives you've considered
This feature can be implemented via environments feature by angular-cli or via dotenv npm package.
Additional context
This feature is related to security and needed in alpha and later releases.

@nirvanaitsolutions nirvanaitsolutions added the enhancement New feature or request label Feb 6, 2019
@nirvanaitsolutions nirvanaitsolutions added this to the accepted milestone Feb 6, 2019
@Shubh1692 Shubh1692 mentioned this issue Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants