Linting in sro_utils

sro_utils/.eslintrc.json

@@ -0,0 +1,18 @@
+{
+    "extends": "airbnb-base",
+    "env": {
+        "mocha": true,
+        "es6": true,
+        "node": true
+    },
+    "parserOptions": { 
+        "ecmaVersion": 6,
+        "sourceType": "module",
+        "ecmaFeatures": {
+            "arrowFunctions": true
+        }
+     },
+     "rules": {
+         "no-extend-native": "off"
+     }
+}

sro_utils/doesPropertyExists/doesPropertyExists.js

@@ -1,9 +1,9 @@
 const _ = require('lodash');
 
 const doesObjectPropertyExists = (object, path) => {
-    const values = [undefined, null, '']
-    if (values.indexOf(_.get(object, path)) > -1 ) return false;
-    return true
+  const values = [undefined, null, ''];
+  if (values.indexOf(_.get(object, path)) > -1) return false;
+  return true;
 };
 
-module.exports = doesObjectPropertyExists;
+module.exports = doesObjectPropertyExists;

sro_utils/doesPropertyExists/doesPropertyExists.test.js

@@ -2,32 +2,32 @@ require('should');
 const doesPropertyExists = require('./doesPropertyExists');
 
 describe('Does Property Exists', () => {
-    const testObj = {
-        subObj: {
-            a: '',
-            b: null,
-            c: undefined,
-            d: 'Hello'
-        }
-    };
-
-    it('Should return false when property is undefined', (done) => {
-        doesPropertyExists(testObj, 'subObj.c').should.be.exactly(false);
-        done();
-    });
+  const testObj = {
+    subObj: {
+      a: '',
+      b: null,
+      c: undefined,
+      d: 'Hello',
+    },
+  };
 
-    it('Should return false when property is null', (done) => {
-        doesPropertyExists(testObj, 'subObj.b').should.be.exactly(false);     
-        done();   
-    });
+  it('Should return false when property is undefined', (done) => {
+    doesPropertyExists(testObj, 'subObj.c').should.be.exactly(false);
+    done();
+  });
 
-    it('Should return false when property is empty', (done) => {
-        doesPropertyExists(testObj, 'subObj.a').should.be.exactly(false);
-        done();
-    });
+  it('Should return false when property is null', (done) => {
+    doesPropertyExists(testObj, 'subObj.b').should.be.exactly(false);
+    done();
+  });
 
-    it('Should return true when property exists', (done) => {
-        doesPropertyExists(testObj, 'subObj.d').should.be.exactly(true);
-        done();
-    });
-});
+  it('Should return false when property is empty', (done) => {
+    doesPropertyExists(testObj, 'subObj.a').should.be.exactly(false);
+    done();
+  });
+
+  it('Should return true when property exists', (done) => {
+    doesPropertyExists(testObj, 'subObj.d').should.be.exactly(true);
+    done();
+  });
+});

sro_utils/doesPropertyExists/index.js

@@ -1,3 +1,3 @@
 const doesPropertyExists = require('./doesPropertyExists');
 
-module.exports = doesPropertyExists;
+module.exports = doesPropertyExists;

sro_utils/getDirectories/getDirectories.js

@@ -1,10 +1,8 @@
 const fs = require('fs');
 const path = require('path');
 
-const getDirectories = (srcpath) => {
-    return fs
-            .readdirSync(srcpath)
-            .filter(file => fs.lstatSync(path.join(srcpath, file)).isDirectory())
-};
+const getDirectories = srcpath => fs
+  .readdirSync(srcpath)
+  .filter(file => fs.lstatSync(path.join(srcpath, file)).isDirectory());
 
-module.exports = getDirectories;
+module.exports = getDirectories;

sro_utils/getDirectories/getDirectories.test.js

@@ -1,34 +1,31 @@
 require('should');
 const mkdirp = require('mkdirp');
 const rmdir = require('rmdir');
-const log = require('../logger');
 const async = require('async');
 const getDirectories = require('./getDirectories');
 
 
 describe('Get Directoriess', () => {
-    before((done) => {
-        async.series([
-            (callback) => {
-                mkdirp('./tmp/test1', callback);
-            },
-            (callback) => {
-                mkdirp('./tmp/test2', callback);
-            }
-        ], done);
-
-    });
+  before((done) => {
+    async.series([
+      (callback) => {
+        mkdirp('./tmp/test1', callback);
+      },
+      (callback) => {
+        mkdirp('./tmp/test2', callback);
+      },
+    ], done);
+  });
 
-    it('Should get all the directories', (done) => {
-        const directories = getDirectories('tmp');
-        directories.length.should.be.exactly(2);
-        directories[0].should.be.exactly('test1');
-        directories[1].should.be.exactly('test2');
-        done();
-    });
+  it('Should get all the directories', (done) => {
+    const directories = getDirectories('tmp');
+    directories.length.should.be.exactly(2);
+    directories[0].should.be.exactly('test1');
+    directories[1].should.be.exactly('test2');
+    done();
+  });
 
-    after((done) => {
-        rmdir('./tmp', done);
-    });
-
-});
+  after((done) => {
+    rmdir('./tmp', done);
+  });
+});

sro_utils/getDirectories/index.js

@@ -1 +1 @@
-module.exports = require('./getDirectories');
+module.exports = require('./getDirectories');

sro_utils/index.js

@@ -1,8 +1,13 @@
+const requireDoesPropertyExists = require('./doesPropertyExists');
+const requireGetDirectories = require('./getDirectories');
+const requireLogger = require('./logger');
+const requireNormalize = require('./normalize');
+
 const sroUtils = {
-  doesPropertyExists: require('./doesPropertyExists'),
-  getDirectories: require('./getDirectories'),
-  logger: require('./logger'),
-  normalize: require('./normalize'),
+  doesPropertyExists: requireDoesPropertyExists,
+  getDirectories: requireGetDirectories,
+  logger: requireLogger,
+  normalize: requireNormalize,
 };
 
 module.exports = sroUtils;

sro_utils/logger/index.js

@@ -1 +1 @@
-module.exports = require('./logger.js');
+module.exports = require('./logger.js');

sro_utils/logger/logger.js

@@ -1,9 +1,8 @@
 const bunyan = require('bunyan');
-const bformat = require('bunyan-format');
 
-const logger = (moduleName) => bunyan.createLogger({
-    name: moduleName,
-    level: 'debug'
+const logger = moduleName => bunyan.createLogger({
+  name: moduleName,
+  level: 'debug',
 });
 
-module.exports = logger;
+module.exports = logger;

sro_utils/normalize/index.js

@@ -1 +1 @@
-module.exports = require('./normalize');
+module.exports = require('./normalize');

sro_utils/normalize/normalize.js

@@ -1,3 +1,3 @@
-String.prototype.normalize = function() {
-    return this.split(/\W+/g).join('_');
-};
+String.prototype.normalize = function normalize() {
+  return this.split(/\W+/g).join('_');
+};

sro_utils/normalize/normalize.test.js

@@ -2,18 +2,17 @@ require('should');
 require('./normalize');
 
 describe('String Utility', () => {
-    it('Should Replace WhiteSpace in string with Underscore', (done) => {
-        const s = "App Engine Support";
-        const modifiedString = s.normalize();
-        modifiedString.should.be.exactly('App_Engine_Support');
-        done();
-    });
-
-    it('Should Replace Period in string with Underscore', (done) => {
-        const s = "Salesforce.com.in";
-        const modifiedString = s.normalize();
-        modifiedString.should.be.exactly('Salesforce_com_in');
-        done();
-    });
+  it('Should Replace WhiteSpace in string with Underscore', (done) => {
+    const s = 'App Engine Support';
+    const modifiedString = s.normalize();
+    modifiedString.should.be.exactly('App_Engine_Support');
+    done();
+  });
 
-});
+  it('Should Replace Period in string with Underscore', (done) => {
+    const s = 'Salesforce.com.in';
+    const modifiedString = s.normalize();
+    modifiedString.should.be.exactly('Salesforce_com_in');
+    done();
+  });
+});