Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refined the tailwind configuration #60

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Conversation

nick-y-ito
Copy link
Member

@nick-y-ito nick-y-ito commented Dec 6, 2023

Changes & Description

  • Removed all the color definitions in globals.css because it's a little redundant in our situation without dark mode.
  • Defined the theme colors in tailwind.config.css to be matched with the Figma design.
  • Defined custom border radiuses in tailwind.config.css to set 10px as default since 10px does not by default exist in Tailwind CSS yet the value is most frequently used over the project.
  • Apply the newly configured theme colors to all the existing components.

Note

@nick-y-ito nick-y-ito linked an issue Dec 6, 2023 that may be closed by this pull request
6 tasks
Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nishiki-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 8:58pm

@nick-y-ito nick-y-ito self-assigned this Dec 6, 2023
@nick-y-ito nick-y-ito added enhancement New feature or request internal labels Dec 6, 2023
@kanta1207
Copy link
Member

kanta1207 commented Dec 6, 2023

@uskayyyyy
Thank you so much for your efforts in refining the Tailwind CSS configuration!
I've reviewed the changes, and everything looks great to me. If you could kindly address the color of the icon in the mobile header, it would be truly appreciated, and then everything will be perfect! 🙏

@nick-y-ito nick-y-ito mentioned this pull request Dec 6, 2023
1 task
@nick-y-ito
Copy link
Member Author

@kanta1207
Thank you for your prompt review! I have fixed the styles of the mobile header. Please recheck it.

Copy link
Member

@kanta1207 kanta1207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

<header className="bg-white sticky top-0 z-40 w-full">
<div className="flex h-12 items-center justify-between">
<Button>
<Icon iconName="arrowLeft" color="gray-dark" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the color for icon in header is set to be black in wireframe.

<Button variant="ghost" size="icon" onClick={() => {}} className="hover:bg-popover">
<Icon iconName="menuCircle" color="popover-foreground" />
<Button>
<Icon iconName="menuCircle" color="gray-dark" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, too. Icon color in header is black in wireframe

@nick-y-ito nick-y-ito merged commit cf5a5ce into develop Dec 6, 2023
4 checks passed
@nick-y-ito nick-y-ito deleted the feat/41-tailwind-config branch December 6, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine style configuration
2 participants