Created a reusable "Drawer" component #89
Conversation
|
LGTM! I'll approve it, but in case you can of course wait for Kota if you want |
| ComponentPropsWithoutRef<typeof PrimitiveOverlay> | ||
| >(({ className, ...props }, ref) => ( | ||
| <PrimitiveOverlay | ||
| className={cn( |
There was a problem hiding this comment.
I liked how you classify className by it's categories!
Maybe we can create a note or doc somewhere about how we classify and organize classNames in cn() method
There was a problem hiding this comment.
That's a good idea!
I was actually considering creating a STYLEGUIDE.md file to document coding rules for a project, such as using I to name interfaces like IMyProps.
Shall we create a new issue for that?
|
@kanta1207 |
| /** | ||
| * This is a custom component that we use to wrap the body (between header and footer) of the dialog. | ||
| */ | ||
| const DialogBody = forwardRef<ElementRef<'div'>, HTMLAttributes<HTMLDivElement>>( |
There was a problem hiding this comment.
Do you still need this DialogBody?
There was a problem hiding this comment.
Oh, Yes, don't care about this comment
Overviews
Created a reusable "Drawer" component and its usage example file.
Review Points
Screenshots
Untitled.mov
Screen.Recording.2023-12-13.at.15.59.36.mov
Screen.Recording.2023-12-13.at.16.04.24.mov