Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to remove all reference to smif config #4

Merged
merged 12 commits into from
Feb 11, 2019
Merged

Refactor to remove all reference to smif config #4

merged 12 commits into from
Feb 11, 2019

Conversation

willu47
Copy link
Member

@willu47 willu47 commented Feb 11, 2019

  • Remove all data, smif config, wrapper
  • Place wrapper code into main.py module and write initial tests in preparation for further refactoring
  • Update pyscaffold to v3

tomalrussell
tomalrussell approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@tomalrussell tomalrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - is there anything worth noting in issues while this is freshly in mind?

@willu47
Copy link
Member Author

willu47 commented Feb 11, 2019

Added issues #5 and #6

@willu47 willu47 merged commit 166bfd0 into master Feb 11, 2019
@willu47 willu47 deleted the refactor branch February 11, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomalrussell tomalrussell tomalrussell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@willu47 @tomalrussell